Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #1017

Merged
merged 9 commits into from
Sep 8, 2021
Merged

3 ➡️ 4 #1017

merged 9 commits into from
Sep 8, 2021

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo3 to ign-gazebo4

Branch comparison: ign-gazebo4...ign-gazebo3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 9 commits August 16, 2021 09:34
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
* Improved doxygen

Signed-off-by: ahcorde <ahcorde@gmail.com>

* Improved docs

Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Sep 8, 2021
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2021
@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #1017 (b278ccc) into ign-gazebo4 (1e6a9d1) will increase coverage by 0.02%.
The diff coverage is 22.22%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo4    #1017      +/-   ##
===============================================
+ Coverage        67.11%   67.13%   +0.02%     
===============================================
  Files              243      243              
  Lines            18210    18215       +5     
===============================================
+ Hits             12222    12229       +7     
+ Misses            5988     5986       -2     
Impacted Files Coverage Δ
include/ignition/gazebo/EntityComponentManager.hh 100.00% <ø> (ø)
include/ignition/gazebo/Server.hh 100.00% <ø> (ø)
include/ignition/gazebo/ServerConfig.hh 100.00% <ø> (ø)
include/ignition/gazebo/Util.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/ContactSensor.hh 100.00% <ø> (ø)
include/ignition/gazebo/components/Factory.hh 96.05% <ø> (ø)
...nclude/ignition/gazebo/components/LogicalCamera.hh 100.00% <ø> (ø)
...nclude/ignition/gazebo/components/Serialization.hh 100.00% <ø> (ø)
include/ignition/gazebo/gui/GuiSystem.hh 0.00% <0.00%> (ø)
include/ignition/gazebo/rendering/SceneManager.hh 100.00% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e6a9d1...b278ccc. Read the comment docs.

@chapulina chapulina merged commit de6676e into ign-gazebo4 Sep 8, 2021
@chapulina chapulina deleted the chapulina/3_to_4 branch September 8, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants